Changeset 1850

Timestamp:

01/28/2008 02:56:44 PM (12 months ago)

Author:

Geert

Message:

Router->filter_uri() regex optimization:

• Made + possessive: this regex should never ever do any useless backtracking.
  
• Added D modifier: this regex should never ever allow final linebreaks.
  

Files:

• trunk/system/libraries/Router.php (modified) (1 diff)

trunk/system/libraries/Router.php

@@ -271 +271 @@
                 if ($str != '' AND ($allowed = Config::item('routes._allowed')) != '')
                 {
-                        if ( ! preg_match('|^['.preg_quote($allowed).']+$|iu', $str))
+                        if ( ! preg_match('|^['.preg_quote($allowed).']++$|iuD', $str))
                         {
                                 header('HTTP/1.1 400 Bad Request');