Changeset 217

Timestamp:

06/16/2007 04:42:35 AM (19 months ago)

Author:

Geert

Message:

url_title() optimization: http://codeigniter.com/forums/viewthread/52307/

Files:

• trunk/system/helpers/url_helper.php (modified) (1 diff)

trunk/system/helpers/url_helper.php

@@ -395 +395 @@
  * @return      string
  */
-function url_title($str, $separator = 'dash')
-{
-        $search  = ($separator == 'dash') ? '_' : '-';
-        $replace = ($separator == 'dash') ? '-' : '_';
-
-        $trans = array(
-                $search                 => $replace,
-                '\s+'                   => $replace,
-                '[^a-z0-9'.$replace.']' => '',
-                $replace.'+'            => $replace,
-                $replace.'$'            => '',
-                '^'.$replace            => ''
-        );
-
-        $str = strip_tags(strtolower($str));
-
-        foreach ($trans as $key => $val)
-        {
-                $str = preg_replace('#'.$key.'#', $val, $str);
-        }
-
-        return trim(stripslashes($str));
+function url_title($str, $separator = 'dash') {
+        
+        // Dashes or underscores?
+        $separator = ($separator == 'dash') ? '-' : '_';
+        
+        // Let's prepare our string.
+        $str = trim($str, " -_\t\n\r");
+        $str = strip_tags($str);
+        $str = strtolower($str);
+        
+        // Time for the hard work now, just two regexes.
+        $str = preg_replace('/[-_\s]+/', $separator, $str);
+        $str = preg_replace('/[^a-z0-9'. $separator .']/', '', $str);
+        
+        return $str;
 }