Changeset 2574

Timestamp:

04/25/2008 11:14:12 AM (6 months ago)

Author:

Geert

Message:

Follow-up to r2567. Removing html::specialchars() calls I added in r2548 and r2549. Those are now superfluous. Router takes care of it already.

Location:

trunk/system

Files:

• helpers/form.php (modified) (1 diff)
• libraries/Pagination.php (modified) (1 diff)
• libraries/Router.php (modified) (1 diff)
• libraries/View.php (modified) (1 diff)

trunk/system/helpers/form.php

@@ -43 +43 @@
 
                 // Form opening tag
-                $form = '<form action="'.html::specialchars($action, FALSE).'"'.form::attributes($attr).'>'."\n";
+                $form = '<form action="'.$action.'"'.form::attributes($attr).'>'."\n";
 
                 // Add hidden fields immediate after opening tag

trunk/system/libraries/Pagination.php

@@ -126 +126 @@
                 }
 
-                // Prevent XSS
-                $this->url = html::specialchars($this->url);
-
                 // Core pagination values
                 $this->total_items        = (int) max(0, $this->total_items);

trunk/system/libraries/Router.php

@@ -125 +125 @@
                 }
 
-                //Last chance to set routing before a 404 is triggered
+                // Last chance to set routing before a 404 is triggered
                 Event::run('system.post_routing');
-                
+
                 if (empty(self::$controller))
                 {

trunk/system/libraries/View.php

@@ -173 +173 @@
         {
                 if (isset($this->data[$key]))
-                {
                         return $this->data[$key];
-                }
-                if(isset($this->$key))
-                {
+
+                if (isset($this->$key))
                         return $this->$key;
-                }               
         }