Changeset 2914

Timestamp:

06/25/2008 05:45:11 PM (5 months ago)

Author:

Shadowhand

Message:

Optimizing form::open() and form::attributes()

Files:

• trunk/system/helpers/form.php (modified) (3 diffs)

trunk/system/helpers/form.php

@@ -42 +42 @@
                 }
 
+                // Set action
+                $attr['action'] = $action;
+
                 // Form opening tag
-                $form = '<form action="'.$action.'"'.form::attributes($attr).'>'."\n";
+                $form = '<form'.form::attributes($attr).'>'."\n";
 
                 // Add hidden fields immediate after opening tag
@@ -452 +455 @@
                         return '';
 
-                if ($type === NULL AND ! empty($attr['type']))
-                {
-                        // Set the type by the attributes
-                        $type = $attr['type'];
-                }
-
                 if (isset($attr['name']) AND empty($attr['id']) AND strpos($attr['name'], '[') === FALSE)
                 {
+                        if ($type === NULL AND ! empty($attr['type']))
+                        {
+                                // Set the type by the attributes
+                                $type = $attr['type'];
+                        }
+
                         switch ($type)
                         {
@@ -479 +482 @@
                 $order = array
                 (
+                        'action',
+                        'method',
                         'type',
                         'id',