Changeset 2997

Timestamp:

07/08/2008 04:29:13 AM (5 months ago)

Author:

Geert

Message:

Yes, those parentheses do make a difference because alternation is constrained by them. Without them you would be matching extensions that, for example, contain "png" or "gif" *anywhere*. Not good.

Files:

• trunk/system/helpers/file.php (modified) (1 diff)

trunk/system/helpers/file.php

@@ -42 +42 @@
                 $extension = pathinfo($filename, PATHINFO_EXTENSION);
 
-                if (preg_match('/^jpe?g|png|[gt]if|bmp|swf$/', $extension))
+                if (preg_match('/^(?:jpe?g|png|[gt]if|bmp|swf)$/', $extension))
                 {
                         // Disable error reporting