Changeset 3352

Timestamp:

08/21/2008 04:48:22 AM (3 months ago)

Author:

Geert

Message:

Converting the default end character for the text::limit functions to the actual Unicode character.

Why would this be better than using an HTML entity reference--I hear you ask?

• HTML entity references only make sense in contexts where HTML markup is used and interpreted (e.g. _not_ in plain text email).*
  
• As a bonus, you don't need to worry about double encoding when using html::specialchars() on a string that passed through text::limit().
  

*Also see: Unicode Explained by Korpela (p.108)

Files:

• trunk/system/helpers/text.php (modified) (2 diffs)

trunk/system/helpers/text.php

@@ -23 +23 @@
         {
                 $limit = (int) $limit;
-                $end_char = ($end_char === NULL) ? '…' : $end_char;
+                $end_char = ($end_char === NULL) ? '…' : $end_char;
 
                 if (trim($str) === '')
@@ -49 +49 @@
         public static function limit_chars($str, $limit = 100, $end_char = NULL, $preserve_words = FALSE)
         {
-                $end_char = ($end_char === NULL) ? '…' : $end_char;
+                $end_char = ($end_char === NULL) ? '…' : $end_char;
 
                 $limit = (int) $limit;