{5} Assigned, Active Tickets by Owner (Full Description) (8 matches)

I was trying to get the Auth module to work with (today's) SVN version of Kohana and I ran into a few issues.

Something small first, the pivot table should be named 'roles_users' (instead of 'users_roles' as documented in view/install.php).

Secondly, on creating a new user, the Auth_Demo controller runs: <pre><code>if ($user->save() AND $user->add('role', 'login'))</code></pre>

However, the ORM::add method will now try to add a row to the roles_users table with role_id = 'login', while it should be role_id = 1. To me it seems this is because the ORM::add method does load the roles model, but it does not load the actual role based on the roles' name.

I got it running by changing (in the ORM::add method): <pre><code>// Load the model $model = ORM::factory($object);</code></pre>

into: <pre><code>// Load the model $model = ORM::factory($object,$id);</code></pre>

and <pre><code>$model->foreign_key(NULL, $join_table) => $id,</code></pre>

into

<pre><code>$model->foreign_key(NULL, $join_table) => $model->primary_key_value,</code></pre>

I'm not sure if this is entirely correct, maybe you need to check if the supplied ID actually exists?! I'm still in the process of understanding ORM, and the Kohana ORM libraries.

Okay, let's assume someone wants to cut a full size image down to fit into a cropped box size of 300x100 pixels:

$image->resize(300, 100)->crop(300, 100)

This won't work.

Well, it could, but only if the aspect ratio is respective of the desired crop aspect ratio. Instead, what will (almost always) happen is the image will fall inside of the box size required, which in this case is 300x100, and the resulting crop will be smaller on one side, in this case; the width, meaning our final cropped image size will end up being 133x100 for a standard 4:3 image, and even worse for tall images. This just won't do.

To get the desired result; a box size not breaking into the boundaries set for any given input and output aspect ratio, rather than not breaking out of the boundaries set, you need to compare the starting and resulting aspect ratios, and choose a master dimension based on that.

Making a new scale-side option (I don't know, 'CANVAS' maybe, since you're requesting a resulting minimum resulting canvas side to crop from) for this would require the following logic:

// image dimensions passed to resize
// equivalent value: x:1
$ar = $width/$height;

// the current working image size
$dimensions = getimagesize($file->image_path);

/*
 * Determine which side should be used during resize
 * as the master dimension, so we don't break into our
 * given box size.
 *
 */
if ($dimensions[0] >= $dimensions[1]) { // wide

    // wide enough
    if (($dimensions[0]/$ar) >= $dimensions[1])
        $master = IMAGE::HEIGHT;

    // not wide enough for our ar; it would break into the box
    else
        $master = IMAGE::WIDTH;
}
else { // tall

    // tall enough
    if ($dimensions[0] <= ($dimensions[1]/$ar))
        $master = IMAGE::HEIGHT;

    // not tall enough for our ar; it would break into the box
    else
        $master = IMAGE::WIDTH;
}

I'm not totally sure this would work for tall box-fitting—I didn't actually test that. If not, then you would want to check to see if $ar >= 1 for wide, and have another if block. Nothing too bad.

I've added a function called output to the image library to send the proper headers and output an image directly to the browser. Not sure of the best way to implement this, but the way I did it works with GD and ImageMagick?.

I've included patches to: system/libraries/Image.php system/libraries/drivers/Image/GD.php system/libraries/drivers/Image/ImageMagick.php

Hope this helps others (http://forum.kohanaphp.com/comments.php?DiscussionID=362).

Translated files from directory system/i18n to czech language