database should accept more then one direction for oderby

[Jens]

Today I can add more then one columns to order by giving an array. If I have: Col1 desc, Col2 asc it would be nice to give the direction as an array too.

[shaun]

I needed this as well, here's the modifications I made to make it work:

/**
 * Method: orderby
 *  Chooses which column(s) to order the <Database.select> <Database.query> by.
 *
 * Parameters:
 *  orderby   - column(s) to order on, can be an array, single column, or comma seperated list of columns
 *  direction - direction(s) of the order
 *
 * Returns:
 *  The <Database> object
 */
public function orderby($orderby, $direction = '') {
	static $directions = array('ASC', 'DESC', 'RAND()', 'NULL');
	if(!is_array($direction)) {
		$direction = strtoupper(trim($direction));

		if ($direction != '') {
			$direction = (in_array($direction, $directions)) ? ' '. $direction : ' ASC';
		}
	}

	if (empty($orderby)) {
		$this->orderby[] = $direction;
		return $this;
	}

	if ( ! is_array($orderby)) {
		$orderby = explode(',', (string) $orderby);
	}

	$order = array();
	foreach ($orderby as $key => $value) {
		if(!is_numeric($key)) {
			$field = $key;
			$value = strtoupper(trim($value));
			$field_dir = (in_array($value, $directions)) ? ' '. $value : ' ASC';
		} elseif(is_array($direction)) {
			$field = $value;
			$field_dir = strtoupper(trim($direction[$key]));
			echo 'key: '.$key;
			$field_dir = (in_array($field_dir, $directions)) ? ' '. $field_dir : ' ASC';
		} else {
			$field = $value;
			$field_dir = $direction;
		}
		
		$field = trim($field);

		if ($field != '') {
			$order[] = $this->driver->escape_column($field).$field_dir;
		}
	}
	$this->orderby[] = implode(',', $order);
	return $this;
}

You can use it as:

$db->orderby(array('col1' => 'desc', 'col2' => 'asc'));
// or
$db->orderby(array('col1', 'col2'), array('desc', 'asc'));

[Shadowhand]

This will be fixed by the rewrite of Database, currently located in the object_db module.

[Shadowhand]

Functionality is part of #204.

[Shadowhand]

Fixed in r3124.

[Nowaker]

It doesn't work - DB error eppears.

$orm->orderby(array('free_places', 'id'), array('desc', 'desc'));

SQL:

ORDER BY 0 ASC, `1` ASC

[Edy]

try

$orm->orderby(array('free_places' =>'DESC',  'id' => 'DESC'));

[Nowaker]

It wasn't explained in phpDoc. If there were, I would not try orderby(array(...), array(...)).