Ticket #432 (closed Feature Request: fixed)

Opened 5 months ago

Last modified 2 months ago

Validation Library Should make use of "valid" helper

Reported by: allain Assigned to: Shadowhand
Priority: minor Milestone: 2.2
Component: Libraries:Validation Version: SVN HEAD
Keywords: Cc:
SVN Revision (if applicable):

Description

->add_rules('age', 'required', 'numeric') should really work since valid::numeric is defined.

I've attached a patch that makes it check to see if valid::$rule exists.

Attachments

Validation.php.patch (0.5 kB) - added by allain on 02/22/08 16:04:03.

Change History

02/22/08 16:04:03 changed by allain

  • attachment Validation.php.patch added.

(follow-up: ↓ 2 ) 02/22/08 16:07:08 changed by Shadowhand

  • status changed from new to closed.
  • resolution set to invalid.

This is already supported: add_rules('foo', array('valid', 'email')).

(in reply to: ↑ 1 ) 02/22/08 16:14:18 changed by allain

Replying to Shadowhand:

This is already supported: add_rules('foo', array('valid', 'email')).

I know, I read your code. I'm just suggesting a little love for the builtin validation functions that are already defined in the valid helper.

02/22/08 16:44:16 changed by Shadowhand

  • status changed from closed to reopened.
  • resolution deleted.

02/22/08 16:44:28 changed by Shadowhand

  • status changed from reopened to new.
  • owner changed from - No owner - to Shadowhand.

02/22/08 16:44:34 changed by Shadowhand

  • status changed from new to assigned.

02/22/08 16:46:27 changed by Shadowhand

On second thought, this makes sense, since valid:: and Validation are supposed to be very closely related.

02/24/08 11:47:39 changed by Shadowhand

  • milestone changed from 2.1.2 to 2.2.

03/05/08 19:24:20 changed by Shadowhand

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in r2223.

05/30/08 13:35:56 changed by airforce1

thanks get a cool air force ones