Input name instead of input label in Forge matches() validation

[Sqter]

Validation for matches() function outputs $input->name instead of $input->label.

modules/Forge/libraries/Form_Input.php, line 498, function validate:

$this->errors['matches'] = array($input->name);

proposed fix:

$this->errors['matches'] = array($input->label ? utf8::strtolower($input->label) : $input->name);

[Shadowhand]

No idea why you would want to match against the label and not the name. Your "fix" makes no sense.

[Sqter]

Replying to Shadowhand:

No idea why you would want to match against the label and not the name. Your "fix" makes no sense.

I'm not proposing to change the match condition, but just the error message arguments. Here is the change in a bigger context:

before:

if ( ! empty($this->matches))
{
	foreach($this->matches as $input)
	{
		if ($this->value != $input->value)
		{
			// Field does not match
			$this->errors['matches'] = array($input->name);
			break;
		}
	}
}

after:

if ( ! empty($this->matches))
{
	foreach($this->matches as $input)
	{
		if ($this->value != $input->value)
		{
			// Field does not match
			$this->errors['matches'] = array($input->label ? utf8::strtolower($input->label) : $input->name);
			break;
		}
	}
}

[Shadowhand]

Ah-ha, ok, now this makes sense. Thanks.

[Shadowhand]

Fixed in r2983, merged in r2984.

[anonymous]

Milestone 2.1.3 deleted