Forge module : checkbox bug

[bakura]

required validation rule failed !

cause change made to the Form_Input.php line 523:

protected function rule_required() {

if ($this->value === OR $this->value === NULL) {

$this->errorsrequired? = TRUE;

}

}

without updating the corresponding code in the Form_Checkbox line 29

public function get($key) {

if ($key == 'value') {

// Return the value if the checkbox is checked return $this->datachecked? ? $this->datavalue? : FALSE;

}

return parent::get($key);

}

the magic method return FALSE when a checkbox isn't checked... wich mean the rule_required will now always success !!!

should update line 29 with:

return $this->datachecked? ? $this->datavalue? : 'NULL';

[bakura]

sorry, forget wikiformatting :P

required validation rule failed !

cause change made to the Form_Input.php line 523:

	protected function rule_required()
	{
		if ($this->value === '' OR $this->value === NULL)
		{
			$this->errors['required'] = TRUE;
		}
	}

without updating the corresponding code in the Form_Checkbox line 29

	public function __get($key)
	{
		if ($key == 'value')
		{
			// Return the value if the checkbox is checked
			return $this->data['checked'] ? $this->data['value'] : FALSE;
		}

		return parent::__get($key);
	}

the magic method return FALSE when a checkbox isn't checked... wich mean the rule_required will now always success !!!

should update line 29 with:

			return $this->data['checked'] ? $this->data['value'] : 'NULL';

[Shadowhand]

Fixed in r2241/r2704, merged in r2705.