Ticket #567 (closed Feature Request: invalid)

Opened 7 months ago

Last modified 7 months ago

Switch input submit to button submit

Reported by: user Owned by: Shadowhand
Priority: minor Milestone: 2.2
Component: Helpers Version: SVN HEAD
Keywords: Cc:

Description

Form button is more flexible (css, nested tags) and have more advantages (POST/GET value) than input submit.

Change History

  Changed 7 months ago by JAAulde

  • status changed from new to closed
  • resolution set to invalid

First, please properly document what you're opening a ticket against. I will assume this is the form helper. Second, no features should be added to any 2.1.* release, so this would have been against 2.2. Third, form helper has a button method, so use it if you like.

  Changed 7 months ago by user

  • status changed from closed to reopened
  • resolution deleted
  • milestone changed from 2.1.2 to 2.2

1. Is there any other input and button tags that you dont understand ? 2. This is debatable. HTML 4.0 defines new tags for forms and input button will be deprecated 3. Button method is very complicated. Button is like type="button" or reset. Submit is submit. I dont know if you are html/css developer, but if i set <input type="submit"> i must add special class to define, that is button, because IE hasnt understand advanced CSS selectors. (input[type="submit"]). Button tag allows nested tags. With 2 nested SPAN tags, you can create beatiful 3D buttons.

Next, by the buttons you can send values, no titles.

<input type="submit" name="submitAuth" value="Login" />
POST/GET send only title

vs.
<button type="submit" name="submitAuth" value="login" />Login</submit>
<button type="submit" name="submitAuth" value="logout" />Logout</submit>
<button type="submit" name="submitAuth" value="changePassword" />Change Password</submit>

you have only one name of variable

more here: http://particletree.com/features/rediscovering-the-button-element/

So conclusion, when we have method SUBMIT, why we use old techniques ? Its like we said. do Kohana compatible with PHP4. Its comic.

BTW: sorry for my bad english

  Changed 7 months ago by JAAulde

  • status changed from reopened to closed
  • resolution set to invalid

I am still not seeing the problem...

You want this:

<button type="submit" name="submitAuth" value="login" />Login</submit>
<button type="submit" name="submitAuth" value="logout" />Logout</submit>
<button type="submit" name="submitAuth" value="changePassword" />Change Password</submit>

Which form::button() gives you like this:

form::button(array('type'=>'submit', 'id'=>'submitAuth1', 'name'=>'submitAuth', 'value'=>'login'),'Login');
form::button(array('type'=>'submit', 'id'=>'submitAuth2', 'name'=>'submitAuth', 'value'=>'logout'),'Logout');
form::button(array('type'=>'submit', 'id'=>'submitAuth3', 'name'=>'submitAuth', 'value'=>'changePassword'),'Change Password');

As for whether we should or should not still support the Submit inputs, I don't know what to tell you. Why wouldn't we? Kohana is a server side framework which claims to support PHP5 only. It is not a client side framework which claims to only support XHTML 1.1 (or name any other flavor of markup here).

  Changed 7 months ago by Geert

Every self-respecting HTML/CSS developer should never ever even touch the form helper. If you want 100% flexibility and control, handcraft your own HTML, as I do. Absolutely nothing wrong with that.

  Changed 7 months ago by user

Why are you dead-handed and you dont bring modern value to web developers ?. I want to do DataGrid? (Table viewer) as like module. But, as i can see there inst any gratefulness. So i cant do it.

follow-up: ↓ 8   Changed 7 months ago by JAAulde

Why are you dead-handed and you dont bring modern value to web developers ?.

I don't know what that means, but neither I not the form helper are keeping you from replacing inputs of type submit with buttons.

I want to do DataGrid?? (Table viewer) as like module. But, as i can see there inst any gratefulness. So i cant do it.

Again, I understand you don't know English very well and I am trying to take that into account, but I just don't understand what you're trying to say...

  Changed 7 months ago by Geert

I would like to repeat myself.

Forget about the form helper. Code your own HTML. Unlimited flexibility. Move on.

in reply to: ↑ 6   Changed 7 months ago by user

Replying to JAAulde:

Why are you dead-handed and you dont bring modern value to web developers ?. I don't know what that means, but neither I not the form helper are keeping you from replacing inputs of type submit with buttons.

I think, you are retro in HTML/CSS world.

I want to do DataGrid?? (Table viewer) as like module. But, as i can see there inst any gratefulness. So i cant do it. Again, I understand you don't know English very well and I am trying to take that into account, but I just don't understand what you're trying to say...

I'd an aim to create akin module. But now, i havent any aim. (table helper was created)

Geert:

I would like to repeat myself. Forget about the form helper. Code your own HTML. Unlimited flexibility. Move on.

I'v do it. I have using other helpers, but dont using old style coding.

PS: no abuse. I'm trying to perform better framework.

Note: See TracTickets for help on using tickets.