file::extension() needs to check for files existance (r2646)

[brettalton]

http://trac.kohanaphp.com/browser/trunk/system/helpers/file.php?rev=2646#L14

Please add this to file::extension()

if ( ! file_exists($filename))
	return FALSE;

I also want to draw your attention to PHP's function:

return pathinfo($filename, PATHINFO_EXTENSION);

in case preg_replace() doesn't work as expected.

[Shadowhand]

No, it functions exactly as it's intended to. It should not check for the files exists, just return the extension from the filename.

[brettalton]

Fair enough.