Form upload value set incorrectly.

[tterragcnoom]

if validate is called more than once (and it's called on render, so it most probably is). The value of uploads is set incorrectly.

on line 94 of Form_Upload.php it should be: $filename = preg_replace('/\s+/', '_', $filename);

on line 102 of Form_Upload.php it should be: $filepath = $this->directory.'uploadfile-'.uniqid(time()).'-'.$filename;

I think :)

[tterragcnoom]

This seems to be a bigger problem actually because calling validate more than once attempts to move the file more than once (which will obviously fail) but will set the name of the file incorrectly (because a file of that name already exists once validate was already called). Maybe a static variable that keeps track whether or not validate has been called or not?

[Shadowhand]

The validate method should never be called more than once per page load.