__toString() must not throw an exception

[Nowaker]

Code:

$form = new Forge (NULL, 'New camp');
$form->set_attr('class', 'new_camp');

$form
	->input('free_places')
	->class('free_places')
	->label('Free places')
	->rules('required|numeric');

$form
	->submit('Dodaj')
	->class('submit');

echo $form->render();

Error description:

Fatal error: Method View::__toString() must not throw an exception in E:\dev\www\projekty\Kolonie_BMVC\app\controllers\camp_admin.php on line 54

When: Only on numeric.

[Shadowhand]

You need the rule valid_numeric.

[Nowaker]

I agree - my mistake. But - should the error message be more readable than it is now?

[Shadowhand]

It's a PHP error, nothing that we can do about it.

[Nowaker]

A solution:

// File: system/libraries/View.php
// Line: 184

	/**
	 * Magically converts view object to string.
	 *
	 * @return  string
	 */
	public function __toString()
	{
		try
		{
			$str = $this->render();
		}
		catch (Exception $e)
		{
			trigger_error($e->getMessage());
		}
		
		return $str;
	}

Now shows a readable error message without throwing an exception.

[Xobb]

Confirming the bug in SVN. Occurred when updated to the new ORM library. The views were working fine, but after update they seem to be broken.

BTW, the solution provided above is not working =(

[Shadowhand]

Still a PHP error, and would require massive additions of try/catch blocks to fix. It doesn't fit the Kohana philosophy to hijack the way PHP works.

[anonymous]

Milestone 2.1.3 deleted