Updated Auth module

[atomless]

I've edited a few bugs - like the table names in the sql on the install page.

Will currently throw the odd error but I've tested thoroughly and all these are down to the bug in the ORM2 add() method. If you go in and edit the db directly making sure the correct role_id is added to the roles_users then all works perfectly.

I also changed the model code, the ORM driver code and the example controller and it's views a fair bit. I hope people feel it's an improvement!

[atomless]

just updated the update to patch the patch :) - (previous zip replaced by new one) - I just needed to add an extra line of code to make it work with Shadowhand's edit to the ORM library of a few minutes ago.

[Shadowhand]

Can you please resubmit this as a diff/patch? Thanks!

[atomless]

Of course, but I'm not quite sure what that entails?

[Shadowhand]

Running the diff command on your auth directory compared to the current SVN auth directory.

[atomless]

is that ok?

[atomless]

Thought that this might be better described as 'feature request' as I've actually added some extra features?

[atomless]

Updated the zip again - made changes to make it easier to write custom user, role, and user_token models without having to edit the Auth library, inline with : http://trac.kohanaphp.com/changeset/3092

and this forum thread : http://forum.kohanaphp.com/comments.php?DiscussionID=545&page=1

I've only updated the zip file not the patch - Shadowhand, please let me know if you want me to make a new patch.

[Shadowhand]

Your patch is re-implementing things that have already been corrected/changed in trunk. Please merge the Forge replacement and your email registration parts with what is currently in trunk.

[atomless]

Sorry, but can you be more specific about the things that have been corrected in trunk but are not corrected or have regressed in my update?

[Shadowhand]

There are several:

1. The SYSPATH check has been removed in trunk 2. The Template_Controller has already been implemented 3. You've changed some of the copyright notices back to (c)2007 (instead of (c)2007-2008) 4. You converted some spaces in copyrights to tabs (incorrectly) 5. You're using $user->id == 0 checks instead of $user->loaded 6. You've changed some method/param comments, breaking PHPDoc style 7. Comments are not necessary for methods that implement interface methods 8. The belongs_to_many ORM relationship no longer exists, so your Role_Model won't work properly 9. Your Auth install pages re-implement changes

There's probably more, but I stopped looking after 1000 lines.

[Shadowhand]

Sorry about the formatting there, I screwed the pooch on that list.

1. Test
2. Grrr

[atomless]

zip of updated auth module

[atomless]

zip of updated auth module

[atomless]

patch for updated Auth module

[atomless]

I've tried to cover all the changes you mentioned and to get the update code as close to the existing svn as possible without removing the extra features.

Updated the patch and the zip uploaded above.

hmm - not sure why trac chose to add 2 new zips I only uploaded it once!

[atomless]

Shadowhand, is it worth me re-adding the email confirmation parts of this to your newly updated auth code or not?