Ticket #750 (closed Patch: fixed)

Opened 4 months ago

Last modified 4 months ago

Default 'welcome' controller isn't working in latest SVN version

Reported by: rawb Owned by: Shadowhand
Priority: minor Milestone: 2.2
Component: Core Version: SVN HEAD
Keywords: Cc:

Description

The default "welcome" controller appears to be broken in the latest trunk due to the switch to Template_Controller. It's setting the template to 'kohana/template', and then trying to load 'views/welcome' (which is pretty much the same template) in the 'content' variable. I fixed this by:

1. Copying views/welcome.php to system/views/kohana/template.php

2. Removing views/welcome.php

3. Changed controllers/welcome.php to use 'views/welcome_content' for the 'content' variable

I've attached a patch of the changes (to welcome.php and template.php) that fixed it for me. I've only been using Kohana for about a week, so I'm not sure if this is the best way to fix this problem. :)

Attachments

welcome.php.patch (0.8 kB) - added by rawb 4 months ago.
template.php.patch (2.0 kB) - added by rawb 4 months ago.

Change History

Changed 4 months ago by rawb

Changed 4 months ago by rawb

Changed 4 months ago by Shadowhand

  • status changed from new to closed
  • resolution set to invalid

Has already been fixed in r3281. Please make sure you are completely up to date before submitting tickets.

Changed 4 months ago by rawb

  • status changed from closed to reopened
  • resolution deleted

I was using r3281, and it is not fixed. It still returns 'Undefined variable: title' on a fresh checkout.

Changed 4 months ago by OscarB

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r3285 and r3286. Thanks rawb.

Changed 4 months ago by rawb

  • status changed from closed to reopened
  • resolution deleted

Actually, while we're on the subject of the welcome/index page, the paragraph text is now slightly out-of-date. It currently reads:

To change what gets displayed for this page, edit application/controllers/welcome.php.

To change this text, edit application/views/welcome.php and application/views/welcome_content.php. 

It should now be:

To change what gets displayed for this page, edit application/controllers/welcome.php.

To change this text, edit application/views/welcome_content.php.

Changed 4 months ago by OscarB

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r3288 Third time lucky ;)

Note: See TracTickets for help on using tickets.